CI Initial commit #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m0dular The workflows wont run on first commit from a fork, I don't know whether we should commit to MAIN and resolve any issues post commit, or merge into a branch and check there first before promoting to MAIN, what do you think? |
|
Kicked off the tests with a dummy pr. |
MartyEwings
approved these changes
May 25, 2021
There was a problem hiding this comment.
@m0dular looks good to me now, Looks like the open ended Puppet Version was not something the test matrix script was expecting, I also think this is a metadata formatting issue that would flag in latest PDK anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.